https://bugzilla.redhat.com/show_bug.cgi?id=1272187 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Paul Howarth <paul@xxxxxxxxxxxx> --- Review ====== Provides -------- $ rpm -qp --provides python2-google-api-client-1.4.2-3.fc24.noarch.rpm python-google-api-client = 1.4.2-3.fc24 python-google-api-client(x86-64) = 1.4.2-3.fc24 python2-google-api-client = 1.4.2-3.fc24 $ rpm -qp --provides python3-google-api-client-1.4.2-3.fc24.noarch.rpm python3-google-api-client = 1.4.2-3.fc24 Requires -------- $ rpm -qp --requires python2-google-api-client-1.4.2-3.fc24.noarch.rpm python(abi) = 2.7 python-httplib2 >= 0.8 python2-oauth2client >= 1.4.6 python2-six >= 1.6.1 python2-uri-templates >= 0.6 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -qp --requires python3-google-api-client-1.4.2-3.fc24.noarch.rpm python(abi) = 3.5 python3-httplib2 >= 0.8 python3-oauth2client >= 1.4.6 python3-six >= 1.6.1 python3-uri-templates >= 0.6 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Review Checklist ---------------- - rpmlint is silent - package and spec file naming OK; difference between source and binary package names may confuse some users but makes sense - package meets guidelines, specifically the Python ones - license is Apache V2, OK for Fedora, matches spec - license text is packaged in %license - spec file written in English and is legible - source tarball matches upstream, including timestamp - source builds OK for x86_64 in Rawhide - buildreqs sane and (mostly) versioned as per upstream's setup.py - no locale data to worry about - no binary libraries to worry about - no bundled libraries included - package is not intended to be relocatable (good) - directory ownership is correct - no duplicate files - permissions are sane - macro usage is consistent - code, not content - no large documentation items - docs don't affect runtime - not a GUI app, no desktop file needed - filenames are all ASCII - no scriptlets present - no inter-package dependency issues - %python_provide macro used correctly - upstream egg is removed in %prep - no dependencies need to be downloaded for build or test - built egg-info is shipped correctly Nits ---- Could specify python version build requirements: python2-devel >= 2.7 (or 2.6 if python-argparse added) python3-devel >= 3.3 Could append "/" to directory names in %files list for clarity Could comment about the code in %prep removing shellbangs without losing timestamps No blocker issues - package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review