https://bugzilla.redhat.com/show_bug.cgi?id=1288643 --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- In the %description, please say what kind of a software library it is, and what algorithms it offers (not an exhaustive list, but a few words of overview). The description can be more than one paragraph, and this way it will show up in searches, and potential users will be able to tell if this is useful for them much more easily. - license is most OK (boost) Change to: License: Boost and Public Domain - license file is present, %license is used Also add LICENSE_FOR_EXAMPLE_PROGRAMS.txt to %license. - latest version - requires/provides look OK, but see below - builds and installs fine - scriplets look sane - devel is split out correctly, has a versioned and arched requires on main package rpmlint: dlib.x86_64: W: no-documentation dlib-devel.x86_64: W: summary-not-capitalized C dlib development files Please change to "Development files for dlib". dlib-devel.x86_64: W: only-non-binary-in-usr-lib OK. dlib-devel.x86_64: W: spurious-executable-perm /usr/share/doc/dlib-devel/docs/vs-cmake-gui.png dlib-devel.x86_64: W: spurious-executable-perm /usr/share/doc/dlib-devel/docs/vs_mode_3.png dlib-devel.x86_64: W: spurious-executable-perm /usr/share/doc/dlib-devel/docs/vs_mode_1.png dlib-devel.x86_64: W: spurious-executable-perm /usr/share/doc/dlib-devel/docs/vs_mode_2.png Please fix. dlib-devel.x86_64: W: hidden-file-or-dir /usr/share/doc/dlib-devel/docs/python/.doctrees dlib-devel.x86_64: W: hidden-file-or-dir /usr/share/doc/dlib-devel/docs/python/.doctrees dlib-devel.x86_64: W: hidden-file-or-dir /usr/share/doc/dlib-devel/docs/python/.buildinfo Just remove those in %install or %exclude them. python2-dlib.x86_64: W: no-documentation python3-dlib.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 12 warnings. OK. The examples in python2-dlib and python3-dlib use #!/usr/bin/python. For python2- this is OK, but for python3 it is not, because it introduces a dependency on /usr/bin/pytyhon, i.e. the python2 package. Best option is to sed the header to usr %{__python2} and %{__python3} respectively. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review