Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-SAX-ExpatXS - Perl SAX 2 XS extension to Expat parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244484 ------- Additional Comments From ville.skytta@xxxxxx 2007-06-16 05:41 EST ------- Not taking the review because I wouldn't be approving it as long as t/* are shipped in the main package, but here's a couple of other comments: XML::SAX parser registration/unregistration missing. See perl-XML-SAX and perl-XML-LibXML for examples how to do it (or just copy-paste from http://cachalot.mine.nu/7/SRPMS/perl-XML-SAX-ExpatXS-1.20-0.4.cmn7.src.rpm). BRs on perl(Devel::Peek) and perl(XML::Parser) seem superfluous. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review