[Bug 1149176] Review Request: vdsm-jsonrpc-java - jsonrpc communication lib for ovirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1149176



--- Comment #5 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> ---
Hi Piotr,

As mentioned in comment#3 it's recommended to provide the spec and sprm in it
can be downloaded directly with tools like wget. The Source is pointing to
Version 1.0.8 which is not available in
http://resources.ovirt.org/pub/ovirt-3.5-snapshot/src/vdsm-jsonrpc-java/. At
this point, please update the spec to the lastest ovirt-3.6 bits.

Every change in spec, please update Release and reflect in changelog

Encourage upstream to add a copy of license (COPYING) and use %license macro in
the spec.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines

Probably maven-surefire-provider-junit4 should be replaced by 
maven-surefire-provider-junit

Looks like you will need BuildRequires: gcc
$ rpmbuild -ba vdsm-jsonrpc-java.spec
configure: error: no acceptable C compiler found in $PATH
See `config.log' for more details.
error: Bad exit status from /var/tmp/rpm-tmp.DBtEbl (%build)

A good recommendation is refresh your spec and re-test it using fedora-review
tool, a simple example:
$ fedora-review --rpm-spec -n vdsm-jsonrpc-java-1.0.8-1.XX.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]