https://bugzilla.redhat.com/show_bug.cgi?id=1285515 --- Comment #18 from Shawn Iwinski <shawn@xxxxxxxx> --- (In reply to Remi Collet from comment #16) > [!]: Missing in %doc: Util/*md Util/composer.json > and so, remove them from php dir. > > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/php/Symfony > > Must Own /usr/share/php/Symfony or require php-symfony-common > > > Notice, I'm ok not providing other compat layers (Iconv,Intl,Mbstring,Xml) > This only means if, from composer.json a app have > > Requires: php-composer(symfony/polyfill-intl) > Suggest: php-intl > > We'll have to use, which is fine : > > Requires: php-intl Since RHEL's/Fedora's compiled versions of PHP include the extensions, I thought it best to require the use of the actual extension over the polyfill. > Please fix the 2 small blockers, everything else is ok. Fixed. Diff = https://github.com/siwinski/rpms/commit/a25d03a83d872333a329640fd47f998026e5631c (In reply to Remi Collet from comment #17) > Please also notice than https://github.com/symfony/polyfill/pull/15 is > mandatory for upcomming PHPUnit 5 (I'm still blocked by PHPUnit_Selenium... > but will happen...). Not mandatory for the review, we can wait for upstream > merge, and apply it later, when needed. Based on your last comment on the pull request ("I confirm, this PR is no more required with PHPUnit 5.1.2.") I held off on adding the patch. Spec URL: https://github.com/siwinski/rpms/blob/a25d03a83d872333a329640fd47f998026e5631c/php-symfony-polyfill/php-symfony-polyfill.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony-polyfill-1.0.0-3.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review