[Bug 1279660] Review Request: golang-launchpad-go-xdg-v0 - Go library to use the XDG spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1279660



--- Comment #12 from Adam Goode <adam@xxxxxxxxxxxxx> ---
- I fixed the changelog.
- The name is such because this is explicitly the "v0" branch (launchpad does
it this way).
- Thanks for catching the bug with Requires for golang(launchpad.net/gocheck).
It should be for the unit-test package.

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/gocode/src/launchpad.net/go-xdg

fixed

[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/gocode/src/launchpad.net/go-xdg,
     /usr/share/gocode/src/launchpad.net, /usr/share/gocode,
     /usr/share/gocode/src

fixed. /usr/share/gocode/src is owned by golang

[!]: Changelog in prescribed format.

fixed

[?]: Package is named according to the Package Naming Guidelines.

I think this is good.

[!]: Requires correct, justified where necessary.

Fixed

[!]: Package is not known to require an ExcludeArch tag.

this is needed for golang

[?]: Latest version is packaged.

yes


Rpmlint
-------
Checking: golang-launchpad-go-xdg-v0-devel-0-0.1.20151107bzr.fc24.noarch.rpm
          golang-launchpad-go-xdg-v0-unit-test-0-0.1.20151107bzr.fc24.i686.rpm
          golang-launchpad-go-xdg-v0-0-0.1.20151107bzr.fc24.src.rpm
golang-launchpad-go-xdg-v0-unit-test.i686: E: devel-dependency
golang-launchpad-go-xdg-v0-devel

this is ok for now, but *-unit-test packages will probably become
*-unit-test-devel packages someday.

golang-launchpad-go-xdg-v0-unit-test.i686: W: spelling-error %description -l
en_US gocheck -> go check, go-check, check

ok

golang-launchpad-go-xdg-v0-unit-test.i686: W: tag-in-description C Requires:

fixed

golang-launchpad-go-xdg-v0.src: W: invalid-url Source0:
golang-launchpad-go-xdg-v0-20151107.tar.gz

this is ok since from bzr.





New spec file and SRPM are up in the same place.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12092231

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]