https://bugzilla.redhat.com/show_bug.cgi?id=1271944 --- Comment #5 from Michael Catanzaro <mcatanzaro@xxxxxxxxx> --- One remaining question: [?]: Requires correct, justified where necessary. Note: I don't understand the decision to explicitly require glib2, gtk3, and gtksourceview3. Is it just to ensure the installed versions are not older than the version it was built against? Why did you do this for those dependencies but not the others? (In reply to Kalev Lember from comment #3) > The rule of thumb is that we should always list all directories in %files > that the package creates, with two exceptions: 1) leave it out if the > directory is included in the 'filesystem' package, 2) leave it out if it's > created by something that's in the package's natural dep chain. So fedora-review is wrong. :) (In reply to Kalev Lember from comment #4) > Which test do you mean? I can't see anything that resembles a 'make check' > style test. tests/test-spell.c has a demo or a code sample or something like > that, not a self test that we would be able to run automatically. Ah, OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review