[Bug 1285515] Review Request: php-symfony-polyfill - Symfony polyfills backporting features to lower PHP versions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1285515



--- Comment #11 from Shawn Iwinski <shawn@xxxxxxxx> ---
I see 2 possible options:

1) Always provide ALL polyfills:
https://github.com/siwinski/rpms/blob/e64463828a7c70097d7f7b8463983cc570b5f784/php-symfony-polyfill/php-symfony-polyfill-ALL.spec

    php-composer(ircmaxell/password-compat) and
php-composer(paragonie/random_compat) will also always have to be available in
this case as well.

2) Provide only needed polyfills and provide conditional MACROS to consumer
libraries:
https://github.com/siwinski/rpms/blob/e64463828a7c70097d7f7b8463983cc570b5f784/php-symfony-polyfill/php-symfony-polyfill-MACROS.spec

    Example consumer library usage:
        %if 0%{?php_symfony_polyfill_with_php56}
        Requires: php-composer(symfony/polyfill-php56)
        %endif



I much prefer option #2 because I'd prefer not to have so many no-ops, but I'm
OK with option #1 if you believe it would be better.



(In reply to Remi Collet from comment #9)
> I think it will be simpler to provide everything, whatever the PHP version
> is.
> 
> - this will be better with SCL.

SCL only provides newer versions not older versions correct?


> - this will be noop (bootstrap will be ignored)

Ignored but still processed.


> - this will avoid to have to add test in all consumer library

See macros alternate above.


> Ex: jeremeamia/superclosure requires symfony/polyfill-php56
> 
> See
> https://github.com/remicollet/remirepo/commit/
> 5ac8cde9e3b7323bb01eaba76312529495296fe8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]