https://bugzilla.redhat.com/show_bug.cgi?id=1287120 --- Comment #9 from Arie Bregman <abregman@xxxxxxxxxx> --- (In reply to Robert Buchholz from comment #8) > (In reply to Arie Bregman from comment #7) > > - In %prep, why are you removing requirements files? > > According to Haikel review: "I'd remove *requirements files to prevent pbr > > downloading stuff" > > Is this file generated? I don't see it in the sources and it's not created > during setup.py build. > the name is different. it's requires.txt, I'll change it in the spec. > > - There is no man-page > > not sure I'm following. what should I do about it? > > From what I understand, ryu creates an executable in /usr/bin. That means it > should come with a man page. The Makefile in the doc directory allows > creating man pages using sphinx (this needs additional BuildRequires): make > man ack. > > > > - Is there a reason you're not using %py2_install / %py2_install ? > > it's not working for me. seems like it can't find such macro. > > Which distribution are you building on? Have you tried building in mock? It > works for me in centos-7 and rawhide. yes. I'm using rhel 7.1 > > > - Description "This is Python 3 version." could probably us an article. > > what do you mean? > > I meant that it should probably say "This is the Python 3 version." > ack. > The addition of Python 3 doesn't work unfortunately, as upstream is actually > not Python 3 compatible (SyntaxErrors). It seems conversion is still an > ongoing work there, do you know more? > So this should just build the python2- package only for now. So remove anything related to python 3? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review