Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: olpc-hardware-manager - OLPC hardware manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244370 ------- Additional Comments From jeff@xxxxxxxxxx 2007-06-15 15:45 EST ------- Needs to require dbus-python and pygobject2. I would recommend using "install -p -D -m 0755" to install the files rather than "mkdir -p && cp". Pointers to somewhere where the code can be downloaded so that the files can in the SRPM can be compared. The OLPC git web interface doesn't work well for raw access to the files, so maybe a short script that uses git to clone the repo and check out the proper revision would work. W: olpc-hardware-manager no-documentation Should at least include a copy of the GPL. W: olpc-hardware-manager non-conffile-in-etc /etc/dbus-1/system.d/olpc-hardware-manager.conf Ignore. W: olpc-hardware-manager incoherent-version-in-changelog 0.3.1-1 0.4.1-1.fc8 Needs updated changelog entry. W: olpc-hardware-manager service-default-enabled /etc/init.d/olpc-hardware-manager Probably OK for OLPC but if this package is branched for Fedora it should not be started by default. W: olpc-hardware-manager no-reload-entry /etc/init.d/olpc-hardware-manager Probably OK. W: olpc-hardware-manager strange-permission olpc-hardware-manager 0755 W: olpc-hardware-manager strange-permission hardwaremanager.py 0755 My preference would be to store the files mode 0644 and then to change the permissions when installing. E: olpc-hardware-manager no-cleaning-of-buildroot %install Add a "rm -rf $RPM_BUILD_ROOT" W: olpc-hardware-manager no-%prep-section W: olpc-hardware-manager no-%build-section Add empty W: olpc-hardware-manager mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 1) Easily fixed. I'll upload some patches to fix some of these (and email them to the submitter). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review