https://bugzilla.redhat.com/show_bug.cgi?id=1282640 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- You can probably replace the make line with %make_build. ...and the two make install lines with %make_install install-docs. rm -rf $RPM_BUILD_ROOT is not needed and is not recommended [http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag]. %defattr is not needed [http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions]. Use %{_mandir} for the path, and do not hardcode the compression: /usr/share/man/man1/lpass.1.gz → %{_mandir}/man1/lpass.1.* The changelog has an empty entry at the bottom. Either fill it in or remove. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review