https://bugzilla.redhat.com/show_bug.cgi?id=1287846 --- Comment #17 from mreynolds@xxxxxxxxxx --- (In reply to Michael Schwendt from comment #15) > Created attachment 1102297 [details] > simplify topdir usage in spec file > > > %setup -qc > > mv %{name}-%{version}-1 src_root > > > %build > > pushd src_root > > > %license src_root/LICENSE > > %doc src_root/README > > This is overly complicated. What's the reason for doing it like this and > moving the source topdir to a custom src_root? I was just following the packaging guidelines which said to use the rpmdevtools template: /etc/rpmdevtools/spectemplate-python.spec I now wish I never used this template because I've had to undo almost everything from it > > Note that rpmbuild enters the topdir _automatically_ for every spec section, > provided that it knows what the dir's name is. > > What's the reason for appending -1 to the upstream version anyway? It can be > made to work with rpmbuild, see the attached patch, but as this dubious -1 > will never match the package %release, it isn't helpful. Thank you the patch works great, and it much simpler. Again, I was just trying to follow the guidelines and use the recommended template. It was problematic to being with, which is why I did/hack things the way I did. Also, I have now changed the package name: Spec URL: http://www.port389.org/binaries/python-lib389.spec SRPM URL: http://www.port389.org/binaries/python-lib389-1.0.1-1.fc22.src.rpm I'm still stumped why rpmlint is complaining that the source packages are not the same size: $ rpmlint ./python-lib389-1.0.1-1.fc22.src.rpm python-lib389.src: W: file-size-mismatch python-lib389-1.0.1-1.tar.bz2 = 103613, http://port389.org/binaries/python-lib389-1.0.1-1.tar.bz2 = 9568 1 packages and 0 specfiles checked; 0 errors, 1 warnings. I have even re-downloaded(from the openshift site) the source file to the SOURCES directory. They should be the same, yet rpmlint complains. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review