https://bugzilla.redhat.com/show_bug.cgi?id=1288100 --- Comment #2 from jiri vanek <jvanek@xxxxxxxxxx> --- Hi Omair! Thank you fro review! (In reply to Omair Majid from comment #1) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > - Missing Requires on jpackage-utils. You mean javapackages-tools, right? javapackages-tools added. TY! > - Missing Dist tag. fixed > - The actual license seems to be "MIT" instead of "BSD". Fix the > license field. Hmm.. are you sure? Well.. You know them better. Fixed. > - Package name should be in lower case. renamed > - Deletion of class files and jars should be in %prep, not %build. fixed > > Optional: > - Include a LICENSE file upstream and package it. Not followed for now. As it is one class project, The license in header looks ok for now. Sorry. > [!]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). I'm not able to silence the setup output.I think it is caused by way ho github is packing releases. But I added man page at least... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review