Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xulrunner - XUL Runner https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244374 ------- Additional Comments From panemade@xxxxxxxxx 2007-06-15 07:46 EST ------- rpmlint complained following on SRPM=> E: xulrunner invalid-version 1.9a5pre The version string must not contain the pre, alpha, beta or rc suffixes because when the final version will be out, you will have to use an Epoch tag to make the package upgradable. Instead put it in the release tag like 0.alpha8.1. W: xulrunner summary-ended-with-dot XUL Runner. Summary ends with a dot. W: xulrunner strange-permission xulrunner-mozconfig 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. W: xulrunner strange-permission firefox-1.1-visibility.patch 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. W: xulrunner mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 24) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. rpmlint complained following on RPM => W: xulrunner no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. W: xulrunner devel-file-in-non-devel-package /usr/bin/xulrunner-config A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. E: xulrunner invalid-version 1.9a5pre The version string must not contain the pre, alpha, beta or rc suffixes because when the final version will be out, you will have to use an Epoch tag to make the package upgradable. Instead put it in the release tag like 0.alpha8.1. W: xulrunner summary-ended-with-dot XUL Runner. Summary ends with a dot. E: xulrunner no-jar-manifest /usr/lib/xulrunner-1.9a5pre/chrome/classic.jar The jar file does not contain a META-INF/MANIFEST file. E: xulrunner no-jar-manifest /usr/lib/xulrunner-1.9a5pre/chrome/en-US.jar The jar file does not contain a META-INF/MANIFEST file. E: xulrunner no-jar-manifest /usr/lib/xulrunner-1.9a5pre/chrome/simple.jar The jar file does not contain a META-INF/MANIFEST file. E: xulrunner no-jar-manifest /usr/lib/xulrunner-1.9a5pre/chrome/pippki.jar The jar file does not contain a META-INF/MANIFEST file. E: xulrunner no-jar-manifest /usr/lib/xulrunner-1.9a5pre/chrome/toolkit.jar The jar file does not contain a META-INF/MANIFEST file. E: xulrunner no-jar-manifest /usr/lib/xulrunner-1.9a5pre/chrome/pyxultest.jar The jar file does not contain a META-INF/MANIFEST file. E: xulrunner no-jar-manifest /usr/lib/xulrunner-1.9a5pre/chrome/comm.jar The jar file does not contain a META-INF/MANIFEST file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review