[Bug 1222334] Review Request: bup - Efficient backup system based on git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1222334



--- Comment #19 from Tadej Janež <tadej.j@xxxxxx> ---
William,

(In reply to William Moreno from comment #18)
> There is a unversioned .so library than you must package as a -devel
> subpackage or request upstream to use a versioned version of the file.
> 
> Please see:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.
> so_name_versioning
> http://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

as I said in comment #8, the _helpers.so file represents a private shared
library which is not meant for development purposes, rather it is an essential
part of bup (you can check this with a simple 'grep -rni _helpers' on the bup
source code directory).

The guidelines you point to [1] actually state:
"As an additional complication, some software generates unversioned shared
objects which are not intended to be used as system libraries. These files are
usually plugins or modular functionality specific to an application, and are
not located in the ld library paths or cache. This means that they are not
located directly in /usr/lib or /usr/lib64, or in a directory listed as a
library path in /etc/ld.so.conf (or an /etc/ld.so.conf.d/config file). Usually,
these unversioned shared objects can be found in a dedicated subdirectory under
/usr/lib or /usr/lib64 (e.g. /usr/lib/purple-2/ is the plugin directory used
for libpurple applications). In these cases, the unversioned shared objects do
not need to be placed in a -devel package."

To sum up, /usr/lib64/bup/bup/_helpers.so is an unversioned so-file that is in
a private %_libdir subdirectory which is not in ld path. Therefore, it does not
need to be placed in a -devel subpackage.

> The web subpackage must requires the same arched main package, change too:
> Requires: bup %{?_isa} = %{version}-%{release}

Good catch, thanks!

Fixed it. Here is the: 
- new Spec URL: https://github.com/tjanez/bup-package/blob/f04700b/bup.spec
- new SRPM URL: https://tadej.fedorapeople.org/bup-0.27-0.4.fc23.src.rpm

> Just check this issue and I will aprove this package.

Great, thanks!

Best regards,
Tadej

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]