[Bug 1287846] Review Request: lib389 - python module to access the 389 DIrectory Server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1287846



--- Comment #13 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to mreynolds from comment #12)
> (In reply to Antonio Trande from comment #11)
> > (In reply to mreynolds from comment #10)
> > > Updated spec and srpm have been updated.
> > > 
> > > Thanks,
> > > Mark
> > 
> > Your package cannot be built without the packages required for building. It
> > needs 'python2-devel' at least.
> 
> Okay, yeah this needed some work (BuildRequires) for the mock build to
> success.  
> 
> > 
> > Test your src package on 'koji' or with 'mock':
> > 
> > https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
> > https://fedoraproject.org/wiki/Using_the_Koji_build_system
> > 
> > Also, get used to update the %changelog when you modify the SPEC file.
> > http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
> 
> I haven't been updating the changelog since this has yet to be approved.  I
> was only going to update it with every new respin. Do you want me to update
> it with every change we are making now?

It would be better

> 
> Uploaded new spec file/srpm
> 
> Thanks,
> Mark

Command for testing considers downloading of 'python-krbV' that is already
provided in Fedora. 'setup.py' must use that one in Fedora. 

+ /usr/bin/python2 setup.py test
running test
Searching for python-krbV
Reading https://pypi.python.org/simple/python-krbV/
Best match: python-krbV 1.0.90
Downloading
https://pypi.python.org/packages/source/p/python-krbV/python-krbV-1.0.90.tar.bz2#md5=77758e1bed2387636ca1989f1d122693
Processing python-krbV-1.0.90.tar.bz2
Writing /tmp/easy_install-2QLVGE/python-krbV-1.0.90/setup.cfg
Running python-krbV-1.0.90/setup.py -q bdist_egg --dist-dir
/tmp/easy_install-2QLVGE/python-krbV-1.0.90/egg-dist-tmp-6Ueu61
krb5module.c: In function 'Context_cc_default':
...

Also, tests are not run:

> Ran 0 tests in 0.000s

- Sources used to build the package does not match the upstream source, as
provided in the spec URL.

Source checksums
----------------
http://port389.org/binaries/lib389-1.0.1-1.tar.bz2 :
  CHECKSUM(SHA256) this package     :
96c0648135fd795e3de286d2095af01ac6462556cc1f6dc5ded29b782155b0cf
  CHECKSUM(SHA256) upstream package :
a9e65e0c788e7b2c8f0331c51f9fdc7df0b3459c70c80bde99750d14cbff0403

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]