Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-06-15 04:57 EST ------- OK - Mock : Built on F-7 (x86_64) ? - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License field in spec matches OK - License is GPL OK - License match extras packaging policy licenses allowed OK - License file is included in package OK - Spec in American English OK - Spec is legible. OK - Sources SHOULD match upstream md5sum: 4973c564c96683a921a7f6759906da4e openjpeg_v1_2.tar.gz OK - Package has correct buildroot. OK - extras BuildRequires are not redundant. OK - %build and %install stages are correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories that other packages own. OK - Changelog section is correct. OK - Should function as described. OK - Should package latest version ------------------------------------------- Rpmlint output: ------------------------------------------- OK - silent on both srpm and main/sub package rpm ------------------------------------------- Sub-packages: ------------------------------------------- They need some improvment. according to the scheme of opengjpeg the main package should contain all bin files, that imply to remove -bin subpackage (which not really usefull). And if other packages work with/need-to openjpeg lib for developping work, provide a subpackage named -lib or -n libopenjpeg. Also Changelog file should be in the main package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review