[Bug 230549] Review Request: oxine - Lightweight, purely OSD based xine frontend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: oxine - Lightweight, purely OSD based xine frontend


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230549





------- Additional Comments From lxtnow@xxxxxxxxx  2007-06-15 03:52 EST -------
OK - Mock : Built on F-7 (x86_64)
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License field in spec matches
OK - License is GPL
OK - License match extras packaging policy licenses allowed
OK - License file is included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources SHOULD match upstream md5sum:
618a8cb76ca0f6b3d21c5f8e2be75d72  oxine-0.6.tar.gz
OK - Package has correct buildroot.
OK - extras BuildRequires are not redundant.
OK - %build and %install stages are correct and work.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories that other packages own.
OK - Changelog section is correct.

OK - Should function as described.
OK - Should package latest version

-------------------------------------------
Rpmlint output:
-------------------------------------------
OK - silent on both srpm and rpm.


-------------------------------------------
desktop file:
-------------------------------------------
According to the guidelines this package (as a front-end) should have/provide
a desktop file for the GNOME/KDE/XFCE menu.
But, it's a bit "tame" to provide one without icon file (just my guess).
Does upstream have or plan to provide one ?

Note that wine packages are provided with desktop files which haven't icons
files :( (don't really like them)

------------------------------------------
from spec file:
------------------------------------------
# --without-jsw until we get libjsw packaged, but that won't be very easy

Do you know if someone's working on or plan to ?
I did some work on it few month ago, but i think the hard patching work to do
it's more about building subpackage -calibration (which provide an UI).
Except that, the lib that i built seem work nice with my "sidewinder" gamepad.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]