https://bugzilla.redhat.com/show_bug.cgi?id=1277161 James Hogarth <james.hogarth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |james.hogarth@xxxxxxxxx --- Comment #2 from James Hogarth <james.hogarth@xxxxxxxxx> --- Just a few comments as I'm on a train right now... Can do a full review in a day or so You should be able to use %autosetup and similar make macros Doing a -delete in the find is technically nicer than an exec of rm The directory /var/run is on tmpfs by default so the current spec doesn't account for that, you should make use of tmpfiles.d to create/configure that COPYING should be %license not %doc Is the INSTALL really useful to put in %doc given the rpm does the install? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review