[Bug 1287846] Review Request: lib389 - python module to access the 389 DIrectory Server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1287846



--- Comment #8 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to mreynolds from comment #7)
> > > 
> > > Why?  Please explain.  Since "release" gets %{?dist} I can not reuse
> > > "release" for the source code version/layout.  Using "prerel", or some other
> > > variable, would make future maintenance easier since there are several
> > > places that reference it.
> > 
> > I don't understand your need to make a 'prerel' macro when you can directly
> > set Release as 1%{?dist}.
> > 
> > Can you do a example?
> 
> Sure, so the "full" version is lib389-1.0.1-1

You refer to full "upstream" version, i think.

> 
> The source code is named and packaged this way (just like what we do in
> 389-ds-base), but when I used %{?dist} it changes to:  lib389-1.0.1-1.f22
> for example.
> 
> This is not how the source is laid out(withe dist extension), thus I can not
> use it in most of the spec file.  Then when I do my next minor release it
> will be: lib389-1.0.1-2.  Using a macro I only need to bump this number up
> in one place - not in three places.

Release tag in a SPEC file is a number incremented when you rebuild a package
or do some changes; sometimes it's also occasionally upped by automated tools,
so i guess you cannot keep the Release number syncronized with the release
number of upstream in any case.

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

>BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>Prefix: %{_prefix}
>Vendor: Red Hat Inc. <389-devel@xxxxxxxxxxxxxxxxxxxxxxx>
>rm -rf $RPM_BUILD_ROOT
>Full %clean section
>%defattr(-,root,root,-)

These lines are useless.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]