[Bug 1282080] Review Request: blackshades - First person shooter - protect the VIP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1282080

Antonio Trande <anto.trande@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande@xxxxxxxxx
           Hardware|x86_64                      |Unspecified
            Version|22                          |rawhide



--- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> ---
Please, provide SPEC/SRPM links if you still need a package review.

- /usr/bin/%{name}

Use the macros: http://fedoraproject.org/wiki/Packaging:Guidelines#Macros

- Source0: %{name}-%{version}.tar.gz

Where does source code archive come from?

http://fedoraproject.org/wiki/Packaging:SourceURL

- rm -rf $RPM_BUILD_ROOT

Useless.

- COPYING is not tagged with %license.

http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

- Decription is too ling for a single line:
 
https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/Common_Rpmlint_Issues#description-line-too-long

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]