https://bugzilla.redhat.com/show_bug.cgi?id=1287756 --- Comment #5 from jiri vanek <jvanek@xxxxxxxxxx> --- Spec URL: https://jvanek.fedorapeople.org/copy_jdk_configs/v3/copy-jdk-configs.spec SRPM URL: https://jvanek.fedorapeople.org/copy_jdk_configs/v3/copy-jdk-configs-1-1.src.rpm RPM URL: https://jvanek.fedorapeople.org/copy_jdk_configs/v3/copy_jdk_configs-1-1.noarch.rpm (In reply to Mikolaj Izdebski from comment #3) > Major issues: > > In general, "When naming packages for Fedora, the maintainer must use the > dash '-' as the delimiter for name parts. The maintainer must NOT use an > underscore '_'" [1] Fixed. > > There is no license file installed. You should add license file to upstream > repo and install it using %license macro. Currently I have no intentions to add license. Maybe I will in some future iteration (maybe when We agree with rest of team) But It wil be BSD or some other free license for sure. > > Source0 based on hg repo tip is a bad idea. You should use proper tags > (preferably) or revision numbers / commit IDs. Sure. For now I had added revision number. In future, when there will be releases, it will be replaced by tags. > > Minor/cosmetic issues: > - "Epoch: 0" line is not needed. removed > - Empty sections (%prep, %install) can be removed. unless you insists, I would like to keep them in. Just for "look and know" > - "rm -rf $RPM_BUILD_ROOT" is not needed. removed > - Group: tag is useless, consider removing it. removed (thanx!) > > [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators (In reply to Mikolaj Izdebski from comment #4) > Also there are several typos that need to be fixed in %description: > s/Utlity/Utility/ > s/jdks/JDKs/ > s/config/configuration/ > s/upates/updates/ > add dot at the end of sentence. fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review