[Bug 1265685] Review Request: sylfilter -- a Bayesian spam filter for mailers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1265685



--- Comment #17 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Ranjan Maitra from comment #16)
> (In reply to Ralf Corsepius from comment #15)
> > Any update?
> > 
> > Open issues with *-2:
> > * [MUSTFIX] Not building against external sylpheed
> > - Missing "BuildRequires: sylpheed-devel"
> > - Pass --with-libsylph=sylpheed instead of --with-libsylph=builtin
> >   to %configure
> 
> Why is this a MUSTFIX?
To put it bluntly: because bundling is harmful, stupid and dumb.

Less bluntly: bundling renders packages unmaintainable, vulnerable and causes
bloat.

> Building against sylpheed will mean requiring the
> package for installation. It reduces the package size from 91k to 46k which
> is not much, however, requiring sylpheed for someone who does not intend to
> use sylpheed for this purpose would increase his/her pulled-in RPM size by
> 7.8M (which is what sylpheed's RPM is).
Size-wise bundling causes bloat because each statically linked packages re-adds
the same libraries over and over again.

What causes the bloat in case of sylpheed is the libs* not having been split
out into a separate package and them being packaged together with docs and
binaries. If this is of real concern to you, you can consider to file an RFE
and request a split out of the libs.

> > * [MUSTFIX] no *-devel subpackage
> 
> Will have to fix this: first have to find how to do this.

Coarse (Incomplete) outline:

<snip>
% package devel
Summary: Development files for sylfilter
Requires: sylfilter%{?_isa} = %{version}-%{release}

%description devel
Development files for sylfilter
[...]
%files
%doc README
%license COPYING
%{_bindir}/sylfilter
%{_libdir}/libsylfilter.so.*

%files devel
%{_libdir}/libsylfilter.so
%{_includedir}/sylfilter
</snip>

I hope tot be able have a look into *-3, tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]