[Bug 1271787] Review Request: comic-neue-fonts - A typeface family inspired by Comic Sans

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1271787



--- Comment #5 from Karel Volný <kvolny@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> %clean section is unnecesary.
> %defattr is unnecessary.

well, yeah ... https://bugzilla.redhat.com/show_bug.cgi?id=1271620
I've missed these two

> %_font_pkg macro gets folded into %description. Try moving it to a different
> place.
> (See output from -qpi comic-neue-fonts-2.2-1.fc24.src.rpm).
...
> Rpmlint
> -------
> Checking: comic-neue-fonts-common-2.2-1.fc24.noarch.rpm
>           comic-neue-fonts-2.2-1.fc24.src.rpm
> comic-neue-fonts.src: W: unexpanded-macro %description -l C %_font_pkg

interesting, my rpmlint does not report this

[kvolny@kvolny SRPMS]$ rpmlint comic-neue-fonts-2.2-1.fc23.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[kvolny@kvolny SRPMS]$ rpm -q rpmlint
rpmlint-1.8-2.fc23.noarch

> Looks good, but please fix the %_font_pkg problem.

thanks

I've moved the macro to the end of %install as seen in oxygen-fonts.spec

new versions uploaded -

SPEC: https://kvolny.fedorapeople.org/comic-neue-fonts.spec
SRPM: https://kvolny.fedorapeople.org/comic-neue-fonts-2.2-2.fc23.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=12029123

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]