https://bugzilla.redhat.com/show_bug.cgi?id=1287183 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> --- NON blocking issues: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1024000 bytes in 3 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Maybe you could create a -doc/s sub package Not available LICENSE file in source directory structure Reported @ https://github.com/broune/mathicgb/issues/6 [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 167 files have unknown license. Detailed output of licensecheck in /home/gil/1287183-mathicgb/licensecheck.txt Almost all files report this header (for me is more than enough) // MathicGB copyright 2012 all rights reserved. MathicGB comes with ABSOLUTELY // NO WARRANTY and is licensed as GPL v2.0 or later - see LICENSE.txt. The following source files are without license headers: ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/mathicgb.cpp ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/mathicgb.h ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/checksource/CheckSource.cpp ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/checksource/Scanner.cpp ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/checksource/Scanner.hpp ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/mathicgb/stdinc.h ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/test/monoidPict.in ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/test/monoidPict.seed ./mathicgb-c72c945ba8e18e68e5650e7e4982b86e558abe6c/src/test/pict.in Reported @ https://github.com/broune/mathicgb/issues/6 Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review