[Bug 1286539] Review Request: rdcp - Remote Data Copy (RDMA file copy program)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1286539



--- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Way too many issues in such a tiny package. :-(


> %define debug_package %{nil}

Why that if thousands of packages (compiled C) create proper -debuginfo
packages? Why do you choose to apply this hammer?

https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages


> http://koji.fedoraproject.org/koji/taskinfo?taskID=12011251

Please skim over the build.log file and perform a brief plausibility check?

Why do you package a prebuilt executable instead of compiling it from source
code?

Also notice:
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags


> Packager:       Slava Shwartsman <valyushash@xxxxxxxxx>,
> Roi Dayan <roi.dayan@xxxxxxxxx>

https://fedoraproject.org/wiki/Packaging:Guidelines#Tags


> Group:          System Environment/Daemons

1.) It is no daemon.
2.) /usr/share/doc/rpm/GROUPS 
3.) https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag


rdcp.c
>  * licenses.  You may choose to be licensed under the terms of the GNU
>  * General Public License (GPL) Version 2, available from the file
>  * COPYING in the main directory of this source tree, or the
>  * OpenIB.org BSD license below:

Yet no such COPYING file is included in your source tarball.

The alternative licensing also means that the package is not "License: GPLv2".
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Dual_Licensing_Scenarios


> Requires:       libibverbs librdmacm

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


> ExcludeArch:    s390 s390x

https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support


> %if %{defined suse_version}

To be deleted. Multi-dist conditionals often don't work fully or introduce
packaging mistakes too often.


> Source0:        %{name}-%{version}.tgz

https://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source


> BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag


> %install
> %{__rm} -rf %{buildroot}

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


> %clean

https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean


> %defattr(-, root, root, -)

https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> %doc README.md paper.txt

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]