https://bugzilla.redhat.com/show_bug.cgi?id=1286980 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to Jitka Plesnikova from comment #2) > (In reply to Petr Šabata from comment #1) > > * What's the reason for line 41? The only executable file is author/test.pl; > > why would you care about it? > It was just for prevention. Removed it. Okay. > > * Missing some BRs > > - coreutils, `rm' on line 39, `chmod' on line 41 > > - sed, `sed' line 40 > Added. Ack. > > * The summary is very brief but acceptable. However, I would correct the > > grammar in the description: s/matches/match/ > Updated Ack. > > * The package attempts to run the author tests (xt/*). They're all skipped > > because of the missing dependencies but this could lead to an unexpected > > FTBFS if some of them make it into the buildroot. > > Either disable them (removing the author_test() call from Makefile.PL > > should work) or declare the missing optional BRs. > Disabled author_test. Ack. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review