https://bugzilla.redhat.com/show_bug.cgi?id=1268010 --- Comment #16 from Michael Schwendt <bugs.michael@xxxxxxx> --- > This is purely personal but I don't like the official guideline for git > snapshot version so I'm going back to release (I did upstream release 1.0 > for these packages so it isn't a problem), I wouldn't mind adding the date > but just the date isn't enough (hence my using git describe, which will > give strictly ordered release numbers) If you disagree with the guidelines, consider bringing it up on packaging@ mailing-list. Eventually you may want to package a snapshot, and then you would need to return to the topic anyway. It's the release number that will give a strictly ordered sequence. The git hash is meaningless with regard to updates/upgrades. Release: 0.%{X}.%{alphatag}%{?dist} %{X} is the release number to increment for every update of the package. The leading 0. is only for pre-release versions of the package. %{alphatag} is purely informational and may be as complex as 20110102git9e88d7e not adding much value, since inside the spec file you are supposed to add a comment anyway that would explain how to checkout exactly the same snapshot that has been packaged. If %X is the same for multiple builds of the package, you've not increased it properly, and only then package tools would take into account the values right of it during version comparison. > %changelog https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs > Summary: The mooshika library (libmooshika) This is an example of why package reviews (and creating guidelines) can be a pain. Repeating the package %{name} in %{summary} is really bad style. Can you think of cases when the summary would be displayed without displaying the package name anywhere next to it? https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description > Source: %{name}-%{version}.tar.gz https://fedoraproject.org/wiki/Packaging:SourceURL It's a rather small and simple package. Consider pointing the fedora-review tool at this ticket: fedora-review -b 1268010 It will look for the latest package files (such as in the Spec URL and SRPM URL lines) and perform many checks on a local test-build. Stuff you should be interested in when doing self-reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review