https://bugzilla.redhat.com/show_bug.cgi?id=1286673 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to Petr Pisar from comment #2) > (In reply to Petr Šabata from comment #1) > > * Missing a test dependency: Mouse::Exporter > > t/90-MooseX-NonMoose/031-moose-exporter.t:11 > > t/90-MooseX-NonMoose/031-moose-exporter.t:25 > > t/91-90-with-Any-Moose/031-moose-exporter.t:11 > > t/91-90-with-Any-Moose/031-moose-exporter.t:25 > > > You are right. I thought I put it down there. Added. > > * Consider declaring the minimum M::B version requirement, v0.38. > > > Module::Build has a long history of variable version string length. E.g., > current one is 0.4214. Until version normalization is in effect, it does not > make sense to put the version there. Therefore I keep it without version. > > Updated package is on the same address. Yes, I know but I had to mention it anyway :) -- Approving. By the way, I'll need this in F23; please, build it for it as well. Do not issue an update, though. I'll push it together with the new App::Cmd and Dist::Zilla. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review