https://bugzilla.redhat.com/show_bug.cgi?id=1240116 --- Comment #20 from William Moreno <williamjmorenor@xxxxxxxxx> --- Package Review ============== 1. The doc and common subpackage both ship the license text, I will recomend to include the license text in the common packages and include a weak dependencie in doc: Suggest: python-music21-common Also use weak dependencies in python2 and 3 subpackage to suggest the doc subpackage. 2. The common subpackage include the python2.7 files than are linked to the python3 subpackage. As part of the move of Fedora to python3 by default I will recomend to split the common subpackage to ship the python3.5 files. Currently the common subpackage will requires python2 as the owner of the /usr/lib/python2.7/site-packages/ directory so python3-music21 will require python2 to install python-music21-common. There are many warning about symlinks in both packages, also please check this issue. The best aproach to this common content is to place it in /usr/share but this will require some mayor patching to the code and this will require to work with upstream. 3. Include in python2 and 3 %files %exclude %{python2_sitelib}/music21/LICENSE The license file is in the common subpackage. 3. Consider to include the test directory in both packages into a devel subpackage (python2-name-devel and python3-name-devel), most user will not run the test locally and this will let then get a smaller package to download. 4. Also both packages have a demos directory than do not look to be necesary in run time and can be packaged as subpackages, you can use weak depencies to suggest the user to install the demos subpackages. 5. Package is not known to require an ExcludeArch tag. Builds fails in secondary arches, but looks like there is a issue with the packaging root. RPMLint: 1: python2-music21.noarch: E: explicit-lib-dependency python-matplotlib Not need work, it is a rpmlint issue 2: python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/cpebach /usr/lib/python2.7/site-packages/music21/corpus/cpebach If you change the common to python3 files this warning will be fixed but you will need to check if the link in python2 works fine. 3: python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 Sedout the shebang of this files 4: python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc Request upstream to fix it or propose a patch to update it. 5: python-music21-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt See: https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings ===== MUST items ===== Generic: Pass: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Pass: License field in the package spec file matches the actual license. Pass: License file installed when any subpackage combination is installed. Pass: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Pass: Package contains no bundled libraries without FPC exception. Pass: Changelog in prescribed format. Pass: Sources contain only permissible code or content. NA: Package contains desktop file if it is a GUI application. NA: Development files must be in a -devel package Pass: Package uses nothing in %doc for runtime. Pass: Package consistently uses macros (instead of hard-coded directory names). Pass: Package is named according to the Package Naming Guidelines. Pass: Package does not generate any conflict. Pass: Package obeys FHS, except libexecdir and /usr/target. Pass: If the package is a rename of another package, proper Obsoletes and Provides are present. Paas: Requires correct, justified where necessary. Paas: Spec file is legible and written in American English. Paas: Package contains systemd file(s) if in need. Paas: Large documentation must go in a -doc subpackage. Large could be size Paas: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Paas: Package installs properly. Pass: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Paas: Package requires other packages for directories it uses. Paas: Package must own all directories that it creates. Paas: Package does not own files or directories owned by other packages. Paas: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Paas: Package uses either %{buildroot} or $RPM_BUILD_ROOT Paas: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Paas: Macros in Summary, %description expandable at SRPM build time. Paas: Dist tag is present. Paas: Package does not contain duplicates in %files. Paas: Permissions on files are set properly. Paas: Package use %makeinstall only when make install DESTDIR=... doesn't work. Paas: Package is named using only allowed ASCII characters. Paas: Package does not use a name that already exists. Paas: Package is not relocatable. Paas: Sources used to build the package match the upstream source, as provided in the spec URL. Paas: Spec file name must match the spec package %{name}, in the format %{name}.spec. Paas: File names are valid UTF-8. Paas: Packages must not store files under /srv, /opt or /usr/local Python: Paas: Python eggs must not download any dependencies during the build process. Pass: A package which is used by another package via an egg interface should provide egg info. Paas: Package meets the Packaging Guidelines::Python Paas: Package contains BR: python2-devel or python3-devel Paas: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: NA: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Paas: Final provides and requires are sane (see attachments). NA: Fully versioned dependency in subpackages if applicable. NA: Package functions as described. Paas: Latest version is packaged. Paas: Package does not include license text files separate from upstream. NA: Patches link to upstream bugs/comments/lists or are otherwise justified. NA: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. NA: Package should compile and build into binary rpms on all supported architectures. Paas: %check is present and all tests pass. Paas: Packages should try to preserve timestamps of original installed files. Paas: Packager, Vendor, PreReq, Copyright tags should not be in spec file Paas: Sources can be downloaded from URI in Source: tag Paas: Reviewer should test that the package builds in mock. Paas: Buildroot is not present Paas: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Paas: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. Paas: SourceX is a working URL. Paas: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: Paas: Rpmlint is run on all installed packages. Paas: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-music21-2.1.2-1.fc23.noarch.rpm python3-music21-2.1.2-1.fc23.noarch.rpm python-music21-common-2.1.2-1.fc23.noarch.rpm python-music21-doc-2.1.2-1.fc23.noarch.rpm python-music21-2.1.2-1.fc23.src.rpm python2-music21.noarch: E: explicit-lib-dependency python-matplotlib python2-music21.noarch: W: no-documentation python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python3-music21.noarch: E: explicit-lib-dependency python3-matplotlib python3-music21.noarch: W: no-documentation python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schoenberg /usr/lib/python2.7/site-packages/music21/corpus/schoenberg python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/theoryExercises /usr/lib/python2.7/site-packages/music21/corpus/theoryExercises python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/luca /usr/lib/python2.7/site-packages/music21/corpus/luca python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/josquin /usr/lib/python2.7/site-packages/music21/corpus/josquin python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/mozart /usr/lib/python2.7/site-packages/music21/corpus/mozart python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ciconia /usr/lib/python2.7/site-packages/music21/corpus/ciconia python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann /usr/lib/python2.7/site-packages/music21/corpus/schumann python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/bach /usr/lib/python2.7/site-packages/music21/corpus/bach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/beethoven /usr/lib/python2.7/site-packages/music21/corpus/beethoven python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/cpebach /usr/lib/python2.7/site-packages/music21/corpus/cpebach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/trecento /usr/lib/python2.7/site-packages/music21/corpus/trecento python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/corelli /usr/lib/python2.7/site-packages/music21/corpus/corelli python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/monteverdi /usr/lib/python2.7/site-packages/music21/corpus/monteverdi python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/essenFolksong /usr/lib/python2.7/site-packages/music21/corpus/essenFolksong python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/airdsAirs /usr/lib/python2.7/site-packages/music21/corpus/airdsAirs python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/verdi /usr/lib/python2.7/site-packages/music21/corpus/verdi python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ryansMammoth /usr/lib/python2.7/site-packages/music21/corpus/ryansMammoth python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/handel /usr/lib/python2.7/site-packages/music21/corpus/handel python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/miscFolk /usr/lib/python2.7/site-packages/music21/corpus/miscFolk python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/leadSheet /usr/lib/python2.7/site-packages/music21/corpus/leadSheet python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/oneills1850 /usr/lib/python2.7/site-packages/music21/corpus/oneills1850 python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann_clara /usr/lib/python2.7/site-packages/music21/corpus/schumann_clara python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/haydn /usr/lib/python2.7/site-packages/music21/corpus/haydn python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/weber /usr/lib/python2.7/site-packages/music21/corpus/weber python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/scale/scala/scl /usr/lib/python2.7/site-packages/music21/scale/scala/scl python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/palestrina /usr/lib/python2.7/site-packages/music21/corpus/palestrina python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/demos /usr/lib/python2.7/site-packages/music21/corpus/demos python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laDeplorationDeLaMorteDeJohannesOckeghem.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/4vPerIlludAveProlatum.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/milleRegrets.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/fortunaDunGranTempo.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/adieuMesAmours.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/oVenusBant.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/petiteCamusette.abc python-music21-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt python-music21.src: W: invalid-url Source0: https://github.com/cuthbertLab/music21/releases/download/v.2.1.2/music21-2.1.2.tar.gz HTTP Error 403: Forbidden 5 packages and 0 specfiles checked; 16 errors, 31 warnings. Rpmlint (installed packages) ---------------------------- python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/petiteCamusette.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/milleRegrets.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/adieuMesAmours.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/fortunaDunGranTempo.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/oVenusBant.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/4vPerIlludAveProlatum.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laDeplorationDeLaMorteDeJohannesOckeghem.abc python-music21-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt python2-music21.noarch: E: explicit-lib-dependency python-matplotlib python2-music21.noarch: W: no-documentation python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python3-music21.noarch: E: explicit-lib-dependency python3-matplotlib python3-music21.noarch: W: no-documentation python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/bach /usr/lib/python2.7/site-packages/music21/corpus/bach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/leadSheet /usr/lib/python2.7/site-packages/music21/corpus/leadSheet python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/demos /usr/lib/python2.7/site-packages/music21/corpus/demos python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/palestrina /usr/lib/python2.7/site-packages/music21/corpus/palestrina python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/luca /usr/lib/python2.7/site-packages/music21/corpus/luca python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/theoryExercises /usr/lib/python2.7/site-packages/music21/corpus/theoryExercises python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/scale/scala/scl /usr/lib/python2.7/site-packages/music21/scale/scala/scl python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schoenberg /usr/lib/python2.7/site-packages/music21/corpus/schoenberg python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/haydn /usr/lib/python2.7/site-packages/music21/corpus/haydn python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/essenFolksong /usr/lib/python2.7/site-packages/music21/corpus/essenFolksong python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ryansMammoth /usr/lib/python2.7/site-packages/music21/corpus/ryansMammoth python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/corelli /usr/lib/python2.7/site-packages/music21/corpus/corelli python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/trecento /usr/lib/python2.7/site-packages/music21/corpus/trecento python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann /usr/lib/python2.7/site-packages/music21/corpus/schumann python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/cpebach /usr/lib/python2.7/site-packages/music21/corpus/cpebach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann_clara /usr/lib/python2.7/site-packages/music21/corpus/schumann_clara python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/weber /usr/lib/python2.7/site-packages/music21/corpus/weber python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/oneills1850 /usr/lib/python2.7/site-packages/music21/corpus/oneills1850 python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/airdsAirs /usr/lib/python2.7/site-packages/music21/corpus/airdsAirs python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/josquin /usr/lib/python2.7/site-packages/music21/corpus/josquin python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/monteverdi /usr/lib/python2.7/site-packages/music21/corpus/monteverdi python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ciconia /usr/lib/python2.7/site-packages/music21/corpus/ciconia python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/mozart /usr/lib/python2.7/site-packages/music21/corpus/mozart python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/beethoven /usr/lib/python2.7/site-packages/music21/corpus/beethoven python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/verdi /usr/lib/python2.7/site-packages/music21/corpus/verdi python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/miscFolk /usr/lib/python2.7/site-packages/music21/corpus/miscFolk python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/handel /usr/lib/python2.7/site-packages/music21/corpus/handel 4 packages and 0 specfiles checked; 16 errors, 30 warnings. Requires -------- python-music21-common (rpmlib, GLIBC filtered): python(abi) python-music21-doc (rpmlib, GLIBC filtered): python2-music21 (rpmlib, GLIBC filtered): lilypond mscore numpy python(abi) python-chardet python-enum34 python-jsonpickle python-matplotlib python-mock python-music21-common python-pillow python-six python-webcolors python-xlrd scipy python3-music21 (rpmlib, GLIBC filtered): lilypond mscore python(abi) python-music21-common python3-chardet python3-jsonpickle python3-matplotlib python3-mock python3-numpy python3-pillow python3-scipy python3-six python3-webcolors python3-xlrd Provides -------- python-music21-common: python-music21-common python-music21-doc: python-music21-doc python2-music21: python-music21 python2-music21 python3-music21: python3-music21 Source checksums ---------------- https://github.com/cuthbertLab/music21/releases/download/v.2.1.2/music21-2.1.2.tar.gz : CHECKSUM(SHA256) this package : 5a5521649db0ef1698185d842f566c0b515913e89a55c8c894731f37257abb0a CHECKSUM(SHA256) upstream package : 5a5521649db0ef1698185d842f566c0b515913e89a55c8c894731f37257abb0a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review