[Bug 1278364] Review Request: python-whitenoise - Static file serving for Python web apps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1278364

Julien Enselme <jujens@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #10 from Julien Enselme <jujens@xxxxxxxxx> ---
> Unfortunately the new Python macros are not available in EL, therefore I need to use the old guidelines, as indicated in the warning on top of: https://fedoraproject.org/wiki/Packaging:Python

It' fine then.

> I am not sure about the doc, I had to create two doc packages in another review before. A quick search on available python packages show that more modules have both.

I don't think there is any mention of that in the guidelines. You can leave the
two doc packages.


I still find:
[!]: Avoid bundling fonts in non-fonts packages.
Please add fontawesome-fonts, levien-inconsolata-fonts, lato-fonts as requires
and use symlink to provide these fonts. The RobotoSlab fonts are not packaged
yet. If you intend to package them, please assign me for the review. Otherwise,
I think they should be removed.

But this is a should item, so I won't block the review for that. Package
approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]