https://bugzilla.redhat.com/show_bug.cgi?id=1286444 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- BR: libtool seems to be missing. - Provides: bundled(gnulib) in place as required. Note: Bundled gnulib but no Provides: bundled(gnulib) See: http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Requirement_if_you_bundle - Recommends: eegdev-plugins on the main package would be nice. Review: - license is OK - license file is present, %license is used - scriptlets are sane - provides/requirements are sane (except BR). - latest version - name is OK - builds and installs fine, eegview on top runs fine - rpmlint: eegdev.src: W: spelling-error %description -l en_US biosignals -> bio signals, bio-signals, signals eegdev.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end eegdev.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist eegdev.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands eegdev.x86_64: W: spelling-error %description -l en_US biosignals -> bio signals, bio-signals, signals eegdev.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end eegdev.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist eegdev.x86_64: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands eegdev.x86_64: W: shared-lib-calls-exit /usr/lib64/libeegdev.so.0.0.2 exit@GLIBC_2.2.5 eegdev-devel.x86_64: W: only-non-binary-in-usr-lib 5 packages and 0 specfiles checked; 0 errors, 10 warnings. All OK. Requires -------- eegdev (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) eegdev-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config eegdev(x86-64) libeegdev.so.0()(64bit) pkgconfig(libusb-1.0) pkgconfig(xdffileio) eegdev-debuginfo (rpmlib, GLIBC filtered): eegdev-plugins (rpmlib, GLIBC filtered): eegdev(x86-64) libbluetooth.so.3()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) libxdffileio.so.0()(64bit) rtld(GNU_HASH) Provides -------- eegdev: eegdev eegdev(x86-64) libeegdev.so.0()(64bit) eegdev-devel: eegdev-devel eegdev-devel(x86-64) pkgconfig(eegdev) eegdev-debuginfo: eegdev-debuginfo eegdev-debuginfo(x86-64) eegdev-plugins: eegdev-plugins eegdev-plugins(x86-64) Unversioned so-files -------------------- eegdev-plugins: /usr/lib64/eegdev/biosemi.so eegdev-plugins: /usr/lib64/eegdev/datafile.so eegdev-plugins: /usr/lib64/eegdev/neurosky.so eegdev-plugins: /usr/lib64/eegdev/tobiia.so Looks nice. Please fix up the Requires/Provides/Recommends when importing. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review