[Bug 1269603] Review Request: vim-commentary - Comment stuff out; takes a motion as a target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1269603

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Please link to the raw spec file. Otherwise fedora-review doesn't work ootb.

Yep, looks good. The %description is kind of hard to parse, but I don't use
vim, maybe it would make sense if I did.
I think you should change the Summary to be something like "Comment stuff out
in vim using ...".

- license is OK
- license file is not present, but that's fine for a 35 line script that uses a
common license :)

- requires/provides are ok
- appdata file is present, nice!
- scriptlets are ok
- latest version
- fedora-review doesn't complain
- rpmlint:

vim-commentary.noarch: W: spelling-error %description -l en_US gcc -> cc, g cc
vim-commentary.noarch: W: spelling-error %description -l en_US gc -> cg, g, c
vim-commentary.noarch: W: spelling-error %description -l en_US gcap -> gap,
cap, g cap
All OK.

vim-commentary.noarch: W: invalid-url URL:
http://www.vim.org/scripts/script.php?script_id=3695 HTTP Error 503: Service
Unavailable
Works for me.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]