https://bugzilla.redhat.com/show_bug.cgi?id=1270622 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- IIUC, mcsdbd is a separate thing. It shouldn't be mentioned in %description. %autosetup is nowadays recommended, especially if you have at least one patch. - license is OK - license file is present, %license is used - ldconfig scriptlet is present - -devel subpackage is split correctly - builds fine - latest version - fedora-review says: [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required Please drop that. Also, '%make_install LIBDIR=%{_libdir} PREFIX=%{_prefix}' is probably better than the explicit make invocation. And '%make_build CFLAGS="%{optflags}" LIBDIR=%{_libdir} PREFIX=%{_prefix} DATADIR=%{_datadir}' can be used to trim down make invocation in %build. Use find -delete instead of find -exec rm -f {} ';' . [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sdb- devel , sdb-debuginfo sdb-devel should have Requires: %{name}%{_isa} = %{version}-%{release} (the arch must match too). - rpmlint: sdb.x86_64: W: incoherent-version-in-changelog 0.9.8-1.0e133f1.fc21 ['0.9.8-1.0e133f1.fc24', '0.9.8-1.0e133f1'] Please fix. sdb.src: W: spelling-error Summary(en_US) radare -> radar, radars, rad are sdb.src: W: spelling-error %description -l en_US djb's -> deb's, dab's, dub's sdb.src: W: spelling-error %description -l en_US cdb -> db, cab, cob sdb.src: W: spelling-error %description -l en_US memcache -> sachem sdb.src: W: spelling-error %description -l en_US vala -> lava, val, vale sdb.x86_64: W: spelling-error Summary(en_US) radare -> radar, radars, rad are sdb.x86_64: W: spelling-error %description -l en_US djb's -> deb's, dab's, dub's sdb.x86_64: W: spelling-error %description -l en_US cdb -> db, cab, cob sdb.x86_64: W: spelling-error %description -l en_US memcache -> sachem sdb-devel.x86_64: W: only-non-binary-in-usr-lib sdb-devel.x86_64: W: no-documentation All bogus. 4 packages and 0 specfiles checked; 0 errors, 12 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review