https://bugzilla.redhat.com/show_bug.cgi?id=1286434 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- V=1 should be added to all make invocations, so the flags used are shown. I appears that the minimum flags are lower than that: pjones> zbyszek: you probably want to get -march= and -mcpu= from %optflags and sed in -mtune=SOMETHING instead? ajax> zbyszek: historically the answer is "amd geode lx", which is a ppro minus cmov and nopl kalev> I would argue that it's not worth spending time on working around missing sse2 support Looking in %optflags yields "-march=i686 -mtune=atom". I'd just let it use -march=pentium4 as in the attached patch. I will simply crash on old i686 machines. This seems to be a better option than excluding i686 completely. Also, it seems a better option than removing the check, because if upstream bothered to add a configure check, they probably had a reason. - license is OK - license file is present, %license is used - ldconfig %post is present - builds fine (with the caveat above) - rpmlint: xdffileio.src: W: spelling-error Summary(en_US) realtime -> mealtime, real time, real-time xdffileio.src: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time xdffileio.src: W: spelling-error %description -l en_US convertion -> conversion, convention, convection xdffileio.x86_64: W: spelling-error Summary(en_US) realtime -> mealtime, real time, real-time xdffileio.x86_64: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time xdffileio.x86_64: W: spelling-error %description -l en_US convertion -> conversion, convention, convection xdffileio-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 7 warnings. - provides/requires are sane - -devel has a versioned and arched requirement on the main package - fedora-review has nothing bad to say - please add V=1 to make invocation. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review