[Bug 1285035] Review Request: nodejs-gdal - Node.js bindings to GDAL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1285035

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #9 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
All looks good to me. APPROVED

The installation issue mentioned in the review is the due to the f-r bug, I can
install manually successfully.

two minor issues:

- You should change the permissions of the cleaner script.
nodejs-gdal.src: W: strange-permission nodejs-gdal-cleaner.sh 775

- Add a comment to Patch2
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]