https://bugzilla.redhat.com/show_bug.cgi?id=1278364 Julien Enselme <jujens@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #8 from Julien Enselme <jujens@xxxxxxxxx> --- - You should use the new macros %py(2|3)_build and %py(2|3)_install and build python2 and python3 version from the same folder. See: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file Feel froo not to take into account this comment if this poses problems on el which seems to be one of your target. I don't have an experience of packages for el. - I think you should only create on -doc package. One for both version of python seems redundant. - See the review for other comments. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging [X]: License field in the package spec file matches the actual license. Guidelines. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 56 files have unknown license. Detailed output of licensecheck in /tmp/1278364 -python-whitenoise/licensecheck.txt [!]: License file installed when any subpackage combination is installed. Please install the license file with the doc packages. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 12 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python Please put the python2 package in its own subpackage. It will provide python-whitenoise thanks to the %python_provides macro. [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Please add fontawesome-fonts, levien-inconsolata-fonts, lato-fonts as requires and use symlink to provide these fonts. The RobotoSlab fonts are not packaged yet. If you intend to package them, please assign me for the review. Otherwise, I think they should be removed. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). python2-whitenoise is not provided. See remark above. [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- whitenoise-doc , python3-whitenoise , python3-whitenoise-doc [?]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-whitenoise-2.0.6-1.fc24.noarch.rpm python-whitenoise-doc-2.0.6-1.fc24.noarch.rpm python3-whitenoise-2.0.6-1.fc24.noarch.rpm python3-whitenoise-doc-2.0.6-1.fc24.noarch.rpm python-whitenoise-2.0.6-1.fc24.src.rpm python-whitenoise.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python-whitenoise.noarch: W: spelling-error %description -l en_US nginx -> ginning, gigging python3-whitenoise.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python3-whitenoise.noarch: W: spelling-error %description -l en_US nginx -> ginning, gigging python3-whitenoise.noarch: W: spelling-error %description -l en_US heroku -> Cherokee python3-whitenoise.noarch: W: spelling-error %description -l en_US openshift -> open shift, open-shift, downshift python3-whitenoise.noarch: W: spelling-error %description -l en_US paas -> pass, pas, paras python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/django.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/__pycache__/__init__.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/gzipstatic.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/storage_backport.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/__init__.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/gzip.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/__init__.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/base.cpython-35.opt-1.pyc python-whitenoise.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python-whitenoise.src: W: spelling-error %description -l en_US nginx -> ginning, gigging 5 packages and 0 specfiles checked; 0 errors, 17 warnings. Rpmlint (installed packages) ---------------------------- python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/base.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/__init__.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/gzipstatic.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/django.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/storage_backport.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/__init__.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/__pycache__/__init__.cpython-35.opt-1.pyc python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/gzip.cpython-35.opt-1.pyc 4 packages and 0 specfiles checked; 0 errors, 8 warnings. Requires -------- python-whitenoise (rpmlib, GLIBC filtered): python(abi) python-django python3-whitenoise-doc (rpmlib, GLIBC filtered): python3-whitenoise (rpmlib, GLIBC filtered): python(abi) python3-django python-whitenoise-doc (rpmlib, GLIBC filtered): Provides -------- python-whitenoise: python-whitenoise python-whitenoise(x86-64) python3-whitenoise-doc: python3-whitenoise-doc python3-whitenoise: python3-whitenoise python-whitenoise-doc: python-whitenoise-doc Source checksums ---------------- https://github.com/evansd/whitenoise/archive/9fafc3843781d8934ef34e9f76dc1d10052916cf.tar.gz#/whitenoise-9fafc38.tar.gz : CHECKSUM(SHA256) this package : d5e617580feb621de523c046c7ef469d26f5c0b5766683e029907b742fa81bb2 CHECKSUM(SHA256) upstream package : d5e617580feb621de523c046c7ef469d26f5c0b5766683e029907b742fa81bb2 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1278364 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review