[Bug 1286324] Review Request: python-acme - Python libraries for use of the ACME protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1286324

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
         Depends On|                            |1286321
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Separate build directories are almost certainly unneeded. Removing them will
simplify the spec file drastically.

There is no need for python2 and python3 client scripts:
"If the executables provide the same functionality independent of whether they
are run on top of Python 2 or Python 3, then only one version of the executable
should be packaged."
[https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin]

You do not need to copy html dir. Instead simply specify the directory in
%files as a relative path, it will be copied automatically:

%files doc
doc/_build/html      (or whatever the path is)

The man page should go in the same package as the script.

To create dir and copy in the same line:

install -Dm0644 docs/_build/man/jws.1 %{buildroot}/%{_mandir}/man1/jws.1

To set variables for make and run it in a subdirectory:

make -C docs man html PATH=...


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1286321
[Bug 1286321] Please build for python3 in addition to the existing python2
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]