Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glew - The OpenGL Extension Wrangler Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229419 kwizart@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kwizart@xxxxxxxxx ------- Additional Comments From kwizart@xxxxxxxxx 2007-06-14 07:27 EST ------- Hi, here some comments: - Provides: libglew-devel = %{version}-%{release} Why do you need this ? - CFLAGS="-Iinclude $RPM_OPT_FLAGS" This will replace -Iinclude indeed - so you may need to have this in %prep (to prevent CFLAGS replacement) sed -i -e 's|$(POPT)|%{optflags}|' Makefile - Prefers to uses this at %prep (if possible for the doc generated before make) sed -i 's/\r//' README.txt doc/* But i wonder if this is still necessaray (at least for the README file) - doc sub-package isn't really big, you may consider to merge it with the -devel sub-package...Follow your thoughts about this... - make should uses %{?_smp_mflags} (it seems to work) - rpmlint glew on installed package show: W: glew unused-direct-shlib-dependency /usr/lib64/libGLEW.so.1.4.0 /usr/lib64/libXmu.so.6 W: glew unused-direct-shlib-dependency /usr/lib64/libGLEW.so.1.4.0 /usr/lib64/libXi.so.6 W: glew unused-direct-shlib-dependency /usr/lib64/libGLEW.so.1.4.0 /usr/lib64/libGLU.so.1 W: glew unused-direct-shlib-dependency /usr/lib64/libGLEW.so.1.4.0 /usr/lib64/libXext.so.6 W: glew unused-direct-shlib-dependency /usr/lib64/libGLEW.so.1.4.0 /usr/lib64/libX11.so.6 You may need to have : BuildRequires: libXmu-devel libXi-devel mesa-libGLU-devel libXext-devel but it seems not to solve the issue (see libtool ?! ) You may report this upstream... - Shouldn't we block FE-LEGAL for the sgi problem or is this clear enought for you ? rpmlint complain about W: glew invalid-license Assorted licenses, - cosmetic consideration rpmdev-newspec create a skeleton spec file that makes spec really looks better. I would suggest to use this. Of course this is a minor problem... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review