[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1279056



--- Comment #2 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> %{_libdir}/cmake/LIBMINC/ → this looks suspicious. Cmake puts everything in
> /usr/share/cmake asaic, nothing provides /usr/lib/cmake in Fedora.
arch-dependent packages should go to libdir/cmake/*
> 
> I don't think libminc-devel should require cmake. It should be possible to
> link to the library using other build systems, and cmake is a fairly large
> dep.
will remore
> 
> Rpmlint
> -------
> Checking: libminc-2.3.00-1.fc24.i686.rpm
>           libminc-devel-2.3.00-1.fc24.i686.rpm
>           libminc-debuginfo-2.3.00-1.fc24.i686.rpm
>           libminc-2.3.00-1.fc24.src.rpm
> libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0
> exit@GLIBC_2.0
looks like you got it 2 times, probably bug in rpmlint? What does it mean?
> libminc-debuginfo.i686: W: spurious-executable-perm
> /usr/src/debug/libminc-libminc-2-3-00/volume_io/Geometry/tensors.c
will do chmod -x on that file.
> 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> - latest version is packaged
> - BSD license is OK
> - license file is present, %license is used
> - tests are present and pass
> - ldconfig is called
> - Provides/Requires look sane, apart from the cmake dep.
> 
> Looks fine apart from the minor issues listed above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]