[Bug 1279176] Review Request: isis - Framework to access a large variety of image processing libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1279176



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in isis-adapter-qt4
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

- Why is -applications and -tools seperate?

Rpmlint
-------
Checking: isis-0.7.9-1.fc24.i686.rpm
          isis-devel-0.7.9-1.fc24.i686.rpm
          isis-tools-0.7.9-1.fc24.i686.rpm
          isis-applications-0.7.9-1.fc24.i686.rpm
          isis-adapter-qt4-0.7.9-1.fc24.i686.rpm
          isis-adapter-qt4-devel-0.7.9-1.fc24.i686.rpm
          isis-adapter-itk-devel-0.7.9-1.fc24.i686.rpm
          isis-debuginfo-0.7.9-1.fc24.i686.rpm
          isis-0.7.9-1.fc24.src.rpm
isis.i686: W: shared-lib-calls-exit /usr/lib/libisis_core.so.3.0.0
exit@GLIBC_2.0
Hm, probably an upstream bug.

isis.i686: W: no-documentation
isis-devel.i686: W: no-documentation
isis-devel.i686: E: incorrect-fsf-address
/usr/include/isis/CoreUtils/application.hpp
isis-tools.i686: W: spelling-error %description -l en_US informations ->
information, information's, in formations
Wow, I haven't seen a non-false-positive rpmlint spelling error in a long
while. But this is one. Please fix!

isis-tools.i686: W: spelling-error %description -l en_US imageIO -> image
isis-tools.i686: W: spelling-error %description -l en_US voxel -> vowel
isis-tools.i686: W: no-documentation
isis-tools.i686: W: no-manual-page-for-binary isisdump
isis-tools.i686: W: no-manual-page-for-binary isisflip
isis-tools.i686: W: no-manual-page-for-binary isisconv
isis-tools.i686: W: no-manual-page-for-binary isisraw
isis-tools.i686: W: no-manual-page-for-binary isisdiff
isis-applications.i686: W: spelling-error %description -l en_US voxels ->
vowels
isis-applications.i686: W: no-documentation
isis-applications.i686: W: no-manual-page-for-binary isiscalc
isis-adapter-qt4.i686: W: no-documentation
isis-adapter-qt4.i686: E: library-without-ldconfig-postin
/usr/lib/libisisAdapter_qt4.so.0.0.0
isis-adapter-qt4.i686: E: library-without-ldconfig-postun
/usr/lib/libisisAdapter_qt4.so.0.0.0
Right, see above.

isis-adapter-qt4-devel.i686: W: no-dependency-on
isis-adapter-qt4/isis-adapter-qt4-libs/libisis-adapter-qt4
There's a requirement though the library name, but I think you should add a
versioned dependency:
Requires:       isis-adapter-qt4%{?_isa} = %{version}-%{release}

isis-adapter-qt4-devel.i686: W: no-documentation
isis-adapter-qt4-devel.i686: E: incorrect-fsf-address
/usr/include/isis/Adapter/qmatrixconversion.hpp
isis-adapter-itk-devel.i686: W: no-documentation
isis-adapter-itk-devel.i686: E: incorrect-fsf-address
/usr/include/isis/Adapter/itkAdapter_impl.hpp
isis-adapter-itk-devel.i686: E: incorrect-fsf-address
/usr/include/isis/Adapter/itkAdapter.hpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Core/CoreUtils/application.hpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Core/CoreUtils/application.cpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Adapter/qt4/qmatrixconversion.hpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Adapter/qt4/qmatrixconversion.cpp
9 packages and 0 specfiles checked; 10 errors, 19 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]