Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: astyle - Source code formatter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207896 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-06-14 04:30 EST ------- This package will need some pretty intensive love, because its Makefile (build/Makefile) doesn't really fit into rpm's demands. MUSTFIX: * Package doesn't acknowledge RPM_OPT_FLAGS The cause is before-mentioned Makefile. You need to find a way to correctly pass RPM_OPT_FLAGS to CFLAGS of this package (More on this below). * The Makefile strips the installed binary (/usr/bin/astyle) Packages are not supposed to strip binaries. rpm needs the unstripped binaries to generate debuginfos from them and strips binaries itself after having generated the debuginfos * The spec should use %{_bindir} instead of /usr/bin * BuildRequires: gcc-c++ libstdc++ Putting them into BuildRequires is frowned upon, because these are defaults components of the buildsystem. Please remove. Wrt. build/Makefile: Frankly speaking, build/Makefile is in a shape, I'd seriously recommend not to use it, but to manually compile astyle from inside of the spec. This approach would be feasible if you don't plan to also ship the astyle libs. If you plan to do so, patching build/Makefile would be an appropriate approach. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review