[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1270513



--- Comment #6 from Claudio Rodrigo Pereyra DIaz <claudiorodrigo@xxxxxxxxxxxxxxxxxx> ---
(In reply to Raphael Groner from comment #5)
> Hi Claudio,
> thanks for your review. May I assign this bug to you as you're doing the
> official process?
> 
> Spec URL: https://raphgro.fedorapeople.org/review/openra/newtonsoft-json.spec
> SRPM URL:
> https://raphgro.fedorapeople.org/review/openra/newtonsoft-json-7.0.1-2.fc23.
> src.rpm
> 
> Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11986801
> 
> * Thu Nov 26 2015 Raphael Groner <> - 7.0.1-2
> - fix folders ownership
> - remove obsolete generation of pkgconfig file
> 
> About general discussion of devel subpackages for mono, see bug #477308.
> <rant> IMHO it's generally ridiculous to blow up spec files with generation
> of .pc files that does not bring any real benefit over rpm's own features,
> but so I tried in first step. Instead, mono is able to resolve its
> dependencies and there's virtual Provides: mono(Newtonsoft.Json) </rant>

rpm resolver dependency yes, but without .pc file monodevelop could not
reference the assembly in to any project for development propose.

> > [?]: Patches link to upstream bugs/comments/lists or are otherwise
> >      justified.
> 
> That's not needed, both patches are for Fedora only to ensure package builds
> properly, see the comments.
> 
> > [?]: %check is present and all tests pass.
>
> It's present and all enabled tests pass. We've to disable some tests due to
> in Fedora currently unresolvable dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]