https://bugzilla.redhat.com/show_bug.cgi?id=1284255 Jonas Ådahl <jadahl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jadahl@xxxxxxxxxx --- Comment #1 from Jonas Ådahl <jadahl@xxxxxxxxxx> --- Hey, thanks for packaging this. Here are some comments. (In reply to Igor Gnatenko from comment #0) > Spec URL: > https://ignatenkobrain.fedorapeople.org/for-review/wayland-protocols.spec > SRPM URL: > https://ignatenkobrain.fedorapeople.org/for-review/wayland-protocols-0.1.0-0. > gitf828a43.fc24.src.rpm I don't think a git version of wayland-protocols should ever be installed anywhere, but that's easy to avoid now since version 1.0 was released yesterday. So I think an initial packaging should be the 1.0 release. There is no build-req for gcc. The URL should IMHO be http://wayland.freedesktop.org. No need to do autoreconf etc, since you'd use the tar.xz as source. There is also no need for running "make" because it wouldn't do anything anyway. The XML files should be part of the -devel package. I think it might be enough with only a -devel package. As of now, wayland-protocols is only ever needed as a build requirement and there is no reason to having it installed in any form. In the future maybe a -doc package makes sense, but we don't have relevant documentation to install yet. I'm not sure I see a point in distributing the toplevel README file in a -doc package, but rather the to be generated protocol documentation HTML files. > Description: > wayland-protocols contains Wayland protocols that adds functionality not > available in the Wayland core protocol. Such protocols either adds > completely new functionality, or extends the functionality of some other > protocol either in Wayland core, or some other protocol in > wayland-protocols. > > A protocol in wayland-protocols consists of a directory containing a set > of XML files containing the protocol specification, and a README file > containing detailed state and a list of maintainers. > Fedora Account System Username: ignatenkobrain This second paragraph is only relevant for people looking in the repository, so I think it should be dropped. We currently do not install the README files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review