[Bug 1276938] Review Request: python-nipy - Neuroimaging in Python FMRI analysis package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1276938



--- Comment #3 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> ---
> - Permissions on files are set properly.
>   Note: See rpmlint output
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
> Maybe.
> 
> - py3dir has been removed from the guidelines. You are supposed to use a
> subdirectory of the source directory you create yourself, if it is necessary
> to have a separate source dir. But since nipy uses six, I think that the
> sources might be 2/3 compatible and you could just run both builds from the
> same source directory, and do the path fixups only on the installed files. I
> think that would also simplify the whole spec file, which right now is a bit
> complex.
Will fix it.
> 
> You could use %global _docdir_fmt %{name}
> to avoid installing both 
> /usr/share/doc/python3-nipy/examples/
> and/usr/share/doc/python2-nipy/examples/ 
> *if* they are identical.
Wow! Didn't know about this hack. Will do.
> 
> /usr/bin/env python is probably wrong. Especially in the python3- package.
> All those file permissions issues are not really important though.
Will fix
> 
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/labs/group/onesample.so 775
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/algorithms/graph/_graph.so 775
> python2-nipy.x86_64: E: non-executable-script
> /usr/lib64/python2.7/site-packages/nipy/algorithms/registration/scripting.py
> 644 /usr/bin/env
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/labs/group/twosample.so 775
> python2-nipy.x86_64: E: non-executable-script
> /usr/lib64/python2.7/site-packages/nipy/labs/glm/tests/test_glm.py 644
> /usr/bin/env
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/algorithms/registration/
> _registration.so 775
> python2-nipy.x86_64: E: non-executable-script
> /usr/lib64/python2.7/site-packages/nipy/labs/viz_tools/activation_maps.py
> 644 /usr/bin/env
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/algorithms/statistics/intvol.so 775
> python2-nipy.x86_64: E: non-executable-script
> /usr/lib64/python2.7/site-packages/nipy/labs/glm/setup.py 644 /usr/bin/env
> python2-nipy.x86_64: W: file-not-utf8
> /usr/share/doc/python2-nipy/examples/data/mni_basal_ganglia.nii.gz
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/algorithms/segmentation/
> _segmentation.so 775
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/labs/group/glm_twolevel.so 775
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/labs/bindings/linalg.so 775
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/labs/glm/kalman.so 775
> python2-nipy.x86_64: E: non-executable-script
> /usr/lib64/python2.7/site-packages/nipy/algorithms/registration/tests/
> test_scripting.py 644 /usr/bin/env
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/labs/bindings/wrapper.so 775
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/algorithms/statistics/histogram.so
> 775
> python2-nipy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/nipy/labs/bindings/array.so 
Will fix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]