[Bug 1285428] Review Request: perl-Crypt-ScryptKDF - Scrypt password based key derivation function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1285428



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Crypt-ScryptKDF-0.009-1.fc24.x86_64.rpm | sort | uniq
-c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.22()(64bit)
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Crypt::OpenSSL::Random)
      1 perl(Exporter)
      1 perl(MIME::Base64)
      1 perl(XSLoader)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)

Binary requires are Ok.

$ rpm -qp --provides perl-Crypt-ScryptKDF-0.009-1.fc24.x86_64.rpm | sort | uniq
-c
      1 perl(Crypt::ScryptKDF) = 0.009
      1 perl-Crypt-ScryptKDF = 0.009-1.fc24
      1 perl-Crypt-ScryptKDF(x86-64) = 0.009-1.fc24
Binary provides are Ok.

$ rpmlint ./perl-Crypt-ScryptKDF*
perl-Crypt-ScryptKDF.src: W: spelling-error Summary(en_US) Scrypt -> Crypt, S
crypt, Crypts
perl-Crypt-ScryptKDF.src: W: spelling-error %description -l en_US Scrypt ->
Crypt, S crypt, Crypts
perl-Crypt-ScryptKDF.x86_64: W: spelling-error Summary(en_US) Scrypt -> Crypt,
S crypt, Crypts
perl-Crypt-ScryptKDF.x86_64: W: spelling-error %description -l en_US Scrypt ->
Crypt, S crypt, Crypts
perl-Crypt-ScryptKDF.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Crypt-ScryptKDF/README
2 packages and 1 specfiles checked; 0 errors, 5 warnings.

FIX: Please fix the encoding of README


BuildRequires are almost ok
FIX: Please add gcc and perl-devel, because it is XS package
FIX: Please remove BR perl(ExtUtils::CBuilder), it is not used
TODO: perl(strict) and perl(warnings) should be part of the first section BRs,
      because they are used in Build.PL

Please correct all 'FIX' issues and consider fixing 'TODO' items and provide
new spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]