https://bugzilla.redhat.com/show_bug.cgi?id=1239008 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Just a few comments: * LICENSE.rst - I don't think it is mandatory to add the license file if it is not included, but since you added it and you install the file, it would be nice to include also reference to the upstream issue or commit. - BTW I mis the point of "test -e LICENSE.rst", you probably don't want this kind of conditions in your package. You either ship your license file or the license file coming from the source tarball, but you want to be sure which license file it is. * Exclamation mark in summary - Is the exclamation mark in summary really necessary? If it were dot, rpmlint would complain about it [1]. * Bump the release - It is good habit to bump the release between review cycles. Coming late to the review, I can't see what was actually changed :/ Otherwise the package looks good, though I am not Python packager ... [1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#summary-ended-with-dot -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review