https://bugzilla.redhat.com/show_bug.cgi?id=1284982 Piotr Popieluch <piotr1212@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@xxxxxxxxx --- Comment #2 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- rpmlint gives me two errors: nodejs-iconv.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/iconv/build/Release/iconv.node 775 nodejs-iconv.x86_64: E: backup-file-in-package /usr/lib/node_modules/iconv/lib/iconv.js.orig Package is not "hardened" https://fedoraproject.org/wiki/Changes/Harden_All_Packages checksec --file ./usr/lib/node_modules/iconv/build/Release/iconv.node Partial RELRO Canary found NX enabled DSO No RPATH No RUNPATH Exporting LDFLAGS will fix the "Partial RELRO" part, not sure about the DSO/PIE part. eg. export LDFLAGS="%{?__global_ldflags}" I expect more node modules will have to be modified. For some unknown reason fedora-review fails to install the package. I can install it manually, think I have some issue with fedora-review, the review also lasted longer than one hour to run. I will rerun/try to find out what is going on later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review