https://bugzilla.redhat.com/show_bug.cgi?id=1282903 --- Comment #7 from Nalin Dahyabhai <nalin@xxxxxxxxxx> --- I can sponsor. Package is in pretty good shape. General notes: Line 127 of the .spec file's mention of "devel.file-list" should probably be changed to "unit-test-devel.file-list". I needed to change the definition of "with_unit_test" on line 6 from 1 to 0 to get the build to succeed in mock because the package doesn't contain tests. The Summary: for the devel subpackage could use tweaking, since the subpackage doesn't include the binary. Does the devel subpackage benefit from including the non-license docs? The package %description could be expanded into something longer than the package summary, since the description can be multiple lines. The empty %if/%endif at line 59 can probably just be removed. Results from fedora-review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. - If you haven't yet, please check with Dan if GPLv2+ is the right license for this. Most of the OpenContainers work carries the ASL 2.0 license. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. - Except for debuginfo, of course. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/docker/hooks.d - I expect you'll need to "Requires: runc" if it ends up providing the /usr/libexec/docker/hooks.d directory, or the docker package, unless this is going to be the only thing we package that lives in that directory, in which case this package should also include the directory in its %files list (as "%dir %{_libexecdir}/docker/hooks.d"). [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode/src/github.com, /usr/libexec/docker, /usr/share/gocode, /usr/libexec/docker/hooks.d - These should be owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. - Don't forget to correct the release part of the comment once it's imported. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. - The main package, which provides a binary, might need to be renamed to oci-register-machine-hook to conform to https://fedoraproject.org/wiki/PackagingDrafts/Go if the fact that it's buried under /usr/libexec doesn't exempt it from the guidelines' recommendation. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. - Change "source codes" to "source code". [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [!]: Package complies to the Packaging Guidelines - Spec file name must match the spec package %{name}. (Also listed as its own requirement below.) - Guidelines recommend installing man pages in uncompressed form and listing them in the %files section with a "*" on the end to pick them up after rpm-build has applied whatever form of compression is preferred. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: Rpmlint is run on all rpms the build produces. - The man page unnecessarily has the executable bit set on it. - The package description needs to be line-wrapped. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [ ]: Permissions on files are set properly. - The man page needs the execute bit cleared; everything else is fine. [-]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [!]: Spec file name must match the spec package %{name}, in the format %{name}.spec. - This is from the packaging guidelines. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. - Please go ahead and change the "make" invocation in the %build section to "make %{?_smp_mflags}". [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). - Is the devel package supposed to "Provide: golang(github.com/sallyom/Register) = = %{version}-%{release}"? [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-sallyom-Register-devel , golang-github-sallyom-Register- debuginfo - The devel package doesn't actually require a matching version of the main package, and debuginfo doesn't have this requirement. [ ]: Package functions as described. - When run without any arguments, the tool panics. Otherwise I expect it's probably okay. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. - The package compresses the man page and "install"s the new compressed copy without using the -p flag, so there would be some discrepancies between arches there. If it changes to install an uncompressed man page, it should use "install"'s -p flag. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.13 starting (python version = 3.4.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.13 INFO: Mock Version: 1.2.13 Finish: chroot init INFO: installing package(s): /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-0-0.1.gitffa5786.fc24.x86_64.rpm /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-devel-0-0.1.gitffa5786.fc24.noarch.rpm /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-debuginfo-0-0.1.gitffa5786.fc24.x86_64.rpm /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-debuginfo-0-0.1.gitffa5786.fc24.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 install /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-0-0.1.gitffa5786.fc24.x86_64.rpm /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-devel-0-0.1.gitffa5786.fc24.noarch.rpm /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-debuginfo-0-0.1.gitffa5786.fc24.x86_64.rpm /tmp/tmp/review-golang-github-sallyom-Register/results/golang-github-sallyom-Register-debuginfo-0-0.1.gitffa5786.fc24.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: golang-github-sallyom-Register-0-0.1.gitffa5786.fc24.x86_64.rpm golang-github-sallyom-Register-devel-0-0.1.gitffa5786.fc24.noarch.rpm golang-github-sallyom-Register-debuginfo-0-0.1.gitffa5786.fc24.x86_64.rpm golang-github-sallyom-Register-0-0.1.gitffa5786.fc24.src.rpm golang-github-sallyom-Register.x86_64: W: spelling-error Summary(en_US) systemd -> systems, system, system d golang-github-sallyom-Register.x86_64: W: spelling-error %description -l en_US systemd -> systems, system, system d golang-github-sallyom-Register.x86_64: W: incoherent-version-in-changelog 0-0.1.git79c2239 ['0-0.1.gitffa5786.fc24', '0-0.1.gitffa5786'] golang-github-sallyom-Register.x86_64: W: spurious-executable-perm /usr/share/man/man1/oci-register-machine-hook.1.gz golang-github-sallyom-Register-devel.noarch: W: spelling-error Summary(en_US) systemd -> systems, system, system d golang-github-sallyom-Register-devel.noarch: W: spelling-error %description -l en_US systemd -> systems, system, system d golang-github-sallyom-Register-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package golang-github-sallyom-Register. golang-github-sallyom-Register.src: W: spelling-error Summary(en_US) systemd -> systems, system, system d golang-github-sallyom-Register.src: W: spelling-error %description -l en_US systemd -> systems, system, system d 4 packages and 0 specfiles checked; 1 errors, 8 warnings. Requires -------- golang-github-sallyom-Register (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) golang-github-sallyom-Register-devel (rpmlib, GLIBC filtered): golang-github-sallyom-Register-debuginfo (rpmlib, GLIBC filtered): Provides -------- golang-github-sallyom-Register: golang-github-sallyom-Register golang-github-sallyom-Register(x86-64) golang-github-sallyom-Register-devel: golang-github-sallyom-Register-devel golang-github-sallyom-Register-debuginfo: golang-github-sallyom-Register-debuginfo golang-github-sallyom-Register-debuginfo(x86-64) Source checksums ---------------- https://github.com/sallyom/Register/archive/ffa57865cfdaab4e0fe68708004778d0e5ea916d/Register-ffa5786.tar.gz : CHECKSUM(SHA256) this package : 24d2417fa2d74a6d704d59cf30da6325073460a3a3fe83f98692365d0a86c9dd CHECKSUM(SHA256) upstream package : 24d2417fa2d74a6d704d59cf30da6325073460a3a3fe83f98692365d0a86c9dd Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n golang-github-sallyom-Register Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review