https://bugzilla.redhat.com/show_bug.cgi?id=1284989 --- Comment #6 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 8. Remember to always bump Release: tag, and add appropriate %changelog entries, even for review modifications 9. since you addressed removing the -protocol subpkg, may be worth adding an upgrade path for folks you may have that -subpkg installed: Obsoletes: mumble-protocol < 1.2.10-2 10. Since mumble is being built without ice support at the moment, you can drop this from the .spec: # Due to missing ice on ppc64 ExcludeArch: ppc64 11. SHOULD use %license tag for license files, ie replace instances of: %doc LICENSE with %license LICENSE 12. SHOULD address rpmlint interesting warning: mumble.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/mumble SSL_CTX_set_cipher_list per looking at the non-trivial code in src/SSL.cpp and recommendations on: https://fedoraproject.org/wiki/Packaging:CryptoPolicies It would appear that patching src/SSL.cpp would do it, something like changing: QString MumbleSSL::defaultOpenSSLCipherString() { return QLatin1String("EECDH+AESGCM:AES256-SHA:AES128-SHA"); } to QString MumbleSSL::defaultOpenSSLCipherString() { return QLatin1String("PROFILE=SYSTEM"); } Though I'm definitely not sure about this, may be worth consulting with your upstream on this one, to see if they think this is appropriate (or not). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review